forked from bndtools/bnd
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bndtools#5062 JVM Crash in bndtools explorer
I was able to consistently crash the VM by selecting a binary class file in rt.jar from the VM project item and then closing the VM project item. After hundreds of trials I found that the bug was triggered when the getTreeViewer().refresh() was called during a model update. For the record, this happened on the main thread so I cannot see any issue with this. I then made the refresh conditional on a change in the filter text field. For this, an AtomicBoolean dirtyFilter was added. This seemed to work fine now. Of course this does not remove the bug. There is an SWT bug lurking but closing an tree item in the bnd explorer will no longer trigger it. Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
- Loading branch information
Showing
3 changed files
with
9 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters