Drop old events after some time #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matter of the fact is that some events are stuck in the queue and we just can't post tweets for them. As discussed earlier this may be because someone revoked permissions for our app or somehow ran out of their personal API limit - the exact reason is unclear and doesn't really matter. This commit removes events which are stuck in the queue after some time. The reasoning for this is twofold. Firstly the likelihood of actually successfuly posting a tweet which is stuck is very low. As far as I can tell they are just stuck. Secondly posting tweets for notes which are old can be confusing and I'd personally be surprised if I suddently had tweets for notes that are weeks old posted in my profile. This rollout has to happen in two stages. First we start emitting tweet created events containing new data (nostr events). After a week passes we drop all tweet created events that don't have nostr events in them and change the code to no longer support tweet created events with missing nostr events.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matter of the fact is that some events are stuck in the queue and we just can't post tweets for them. As discussed earlier this may be because someone revoked permissions for our app or somehow ran out of their personal API limit - the exact reason is unclear and doesn't really matter.
This commit removes events which are stuck in the queue after some time.
The reasoning for this is twofold. Firstly the likelihood of actually successfuly posting a tweet which is stuck is very low. As far as I can tell they are just stuck. Secondly posting tweets for notes which are old can be confusing and I'd personally be surprised if I suddently had tweets for notes that are weeks old posted in my profile.
This rollout has to happen in two stages. First we start emitting tweet created events containing new data (nostr events). After a week passes we drop all tweet created events that don't have nostr events in them and change the code to no longer support tweet created events with missing nostr events.