Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore rollup plugin cache when publishing #41

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Ignore rollup plugin cache when publishing #41

merged 1 commit into from
Apr 7, 2021
+1 −0

Conversation

herberttn
Copy link
Contributor

@herberttn herberttn commented Apr 6, 2021 •
edited
Loading

Some cache files are being published from the rollup build, which can cause problems with caching routines on some CI environments.
I'm currently having problems to cache node_modules on Github Actions because of them.

image

@planttheidea
Copy link
Owner

planttheidea commented Apr 6, 2021 •
edited
Loading

This is a good change, but is there any benefit to using "files" instead of adding .rpt2_cache to the existing .npmignore? If they are duplicate implementations with the same intent, I think it would be best to coalesce around one. I'm not sure of the trade-offs of using "files" over .npmignore.

@herberttn
Ignore rollup plugin cache when publishing

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0a1f6f6
@herberttn
Copy link
Contributor Author

herberttn commented Apr 6, 2021 •
edited
Loading

This is a good change, but is there any benefit to using "files" instead of adding .rpt2_cache to the existing .npmignore? If they are duplicate implementations with the same intent, I think it would be best to coalesce around one. I'm not sure of the trade-offs of using "files" over .npmignore.

No benefit, they are just the exact opposite of each other (include vs exclude).
I forgot about the .npmignore when I suggested the change!

I've rebased this to add to the ignore, I absolutely agree that using only one is better.

@herberttn herberttn changed the title Select files to be published instead of whole dir Ignore rollup plugin cache when publishing Apr 6, 2021
@planttheidea
Copy link
Owner

Cool, looks good. Later tonight, I'll merge and publish a patch with this fix.

@planttheidea planttheidea merged commit d511979 into planttheidea:master Apr 7, 2021
@planttheidea
Copy link
Owner

This fix has been released as 2.0.1. Thanks for the PR!

@herberttn
Copy link
Contributor Author

This fix has been released as 2.0.1. Thanks for the PR!

Thank you!

@herberttn herberttn deleted the patch-1 branch April 9, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@herberttn @planttheidea