Upgrade Ruby/Rails and other dependencies #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeyci
reviewed
Feb 16, 2020
f1sherman
force-pushed
the
ruby-2-7-0
branch
2 times, most recently
from
d7548db
to
f51e94f
Compare
|
Hi @f1sherman, can you rebase to solve the conflicts so we can take a better look at this? |
f1sherman
force-pushed
the
ruby-2-7-0
branch
from
f51e94f
to
8bd945d
Compare
|
Done! Looks like I have a failing test now. When
|
|
Sounds good, thanks! |
|
#296 has been merged so it should work now if you rebase 🤞 I would also like to get @rjherrera's feedback on this. I reckon the rails upgrade is breaking so maybe it would be more sensible to bundle this with other breaking changes (such as #284 ) for a version 2 release. |
I started out just trying to get specs passing on Ruby 2.7.0, but ended up also upgrading several gems (including Rails) as well.
|
@jgmontoya sounds good, build is passing now! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out just trying to get specs passing on Ruby 2.7.0, which required upgrading Rails, but ended up upgrading several other gems as well.
Let me know if this is going overboard and I should break things up a bit.