Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix searching for ids with selected list input #489

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

vaot
Copy link

@vaot vaot commented Nov 24, 2023

Motivation / Background

  • When searching for multiple fields including id, other searchable inputs force the predicate to eq rather than cont, and selected-list does not, which results in a SQL error.

Detail

This Pull Request changes the predicate to eq when the field is id.

Additional information

From:

{"groupings"=>{"0"=>{"m"=>"or", "name_cont"=>"test", "id_cont"=>"test"}}, "combinator"=>"and"}

To:

{"groupings"=>{"0"=>{"m"=>"or", "name_cont"=>"test", "id_eq"=>"test"}}, "combinator"=>"and"}

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a concise description of what changed and why.
  • Tests are added or updated if you fix a bug or add a feature.
  • Documentation has been added or updated if you add a feature or modify an existing one.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature (under the "Unreleased" heading if this is not a version change).
  • My changes don't introduce any linter rule violations.

@vaot vaot force-pushed the fix-selected-list-input-search-by-id branch from a7f7217 to 24d9ac0 Compare November 25, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant