Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clean up lines for rendering even when the Layer is disabled #6353

Merged
merged 2 commits into from May 13, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented May 10, 2024

Fixes #6345

  • cleanup all the time, regardless of lines getting rendered

@mvaligursky mvaligursky self-assigned this May 10, 2024
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels May 10, 2024
@mvaligursky mvaligursky requested a review from a team May 10, 2024 15:53
Co-authored-by: Will Eastcott <will@playcanvas.com>
@mvaligursky mvaligursky merged commit 374aef1 into main May 13, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-disabled-layer-lines branch May 13, 2024 08:32
mvaligursky added a commit that referenced this pull request May 14, 2024
)

* Fix: Clean up lines for rendering even when the Layer is disabled

* Update src/scene/immediate/immediate-batch.js

Co-authored-by: Will Eastcott <will@playcanvas.com>

---------

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
slimbuck pushed a commit to slimbuck/engine that referenced this pull request May 20, 2024
…aycanvas#6353)

* Fix: Clean up lines for rendering even when the Layer is disabled

* Update src/scene/immediate/immediate-batch.js

Co-authored-by: Will Eastcott <will@playcanvas.com>

---------

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when drawing lines to disabled layer
2 participants