Fix buildUrl relative path support #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildUrl never worked with relative paths as it would always replace the
path in the url instead of adding to it.
Using the other mode of the URL constructor we can use it to always give
us a correct url:
`new URL('glslang/glslang.js', 'https://example.com/foo/bar.html')` is `https://example.com/foo/glslang/glslang.js`
`new URL('/glslang/glslang.js', 'https://example.com/foo/bar.html')` is `https://example.com/glslang/glslang.js`
`new URL('glslang/glslang.js', 'https://example.com/')` is `https://example.com/glslang/glslang.js`
`new URL('/glslang/glslang.js', 'https://example.com/')` is `https://example.com/glslang/glslang.js`
This bug currently prevents Playcanvas Editor exports from being run on
a non root path with WebGPU. It will just pass `glslang.js` as path.
So on a url like https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/
the old code would turn it into https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/glslang.js
whil the actual paths should be https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/glslang.js
mvaligursky
pushed a commit
that referenced
this pull request
May 14, 2024
buildUrl never worked with relative paths as it would always replace the
path in the url instead of adding to it.
Using the other mode of the URL constructor we can use it to always give
us a correct url:
`new URL('glslang/glslang.js', 'https://example.com/foo/bar.html')` is `https://example.com/foo/glslang/glslang.js`
`new URL('/glslang/glslang.js', 'https://example.com/foo/bar.html')` is `https://example.com/glslang/glslang.js`
`new URL('glslang/glslang.js', 'https://example.com/')` is `https://example.com/glslang/glslang.js`
`new URL('/glslang/glslang.js', 'https://example.com/')` is `https://example.com/glslang/glslang.js`
This bug currently prevents Playcanvas Editor exports from being run on
a non root path with WebGPU. It will just pass `glslang.js` as path.
So on a url like https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/
the old code would turn it into https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/glslang.js
whil the actual paths should be https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/glslang.js
slimbuck
pushed a commit
to slimbuck/engine
that referenced
this pull request
May 20, 2024
buildUrl never worked with relative paths as it would always replace the
path in the url instead of adding to it.
Using the other mode of the URL constructor we can use it to always give
us a correct url:
`new URL('glslang/glslang.js', 'https://example.com/foo/bar.html')` is `https://example.com/foo/glslang/glslang.js`
`new URL('/glslang/glslang.js', 'https://example.com/foo/bar.html')` is `https://example.com/glslang/glslang.js`
`new URL('glslang/glslang.js', 'https://example.com/')` is `https://example.com/glslang/glslang.js`
`new URL('/glslang/glslang.js', 'https://example.com/')` is `https://example.com/glslang/glslang.js`
This bug currently prevents Playcanvas Editor exports from being run on
a non root path with WebGPU. It will just pass `glslang.js` as path.
So on a url like https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/
the old code would turn it into https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/glslang.js
whil the actual paths should be https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/glslang.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildUrlnever worked with relative paths as it would always replace the path in the url, instead of adding to it.Using the other mode of the URL constructor we can use it to always give us a correct url:
This bug currently prevents Playcanvas Editor exports from being run on a non root path with WebGPU. The editor export will pass just
glslang.jsas path.So on a url like https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/index.html
the old code would turn it into https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/glslang.js
while the actual paths should be https://94176748-9ef8-42c9-a44e-a95b70ec5680.poki-gdn.com/7a8f1fc6-7162-473a-b1dc-4479ed5d60cf/glslang.js
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.