Merge pull request #342 from DukeManh/issue-157

Fix false positive binding with opening {
player-ui · May 3, 2024 · cef2a5f · cef2a5f
2 parents f1c0d8c + d878180
commit cef2a5f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/core/player/src/binding-grammar/__tests__/test-utils/ast-cases.ts b/core/player/src/binding-grammar/__tests__/test-utils/ast-cases.ts
@@ -185,6 +185,7 @@ export const INVALID_AST_PARSER_TESTS: Array<string> = [
   'foo.bar[',
   'foo.bar.{{nested.}',
   'foo.bar`not done()',
+  '{foo.bar',
 ];
 
 export const VALID_AST_PARSER_CUSTOM_TESTS: Array<[string, PathNode]> = [

diff --git a/core/player/src/binding-grammar/custom/index.ts b/core/player/src/binding-grammar/custom/index.ts
@@ -146,15 +146,13 @@ export const parse: Parser = (path) => {
   const nestedPath = (): PathNode | undefined => {
     if (ch === OPEN_CURL) {
       next(OPEN_CURL);
-      if (ch === OPEN_CURL) {
-        next(OPEN_CURL);
-
-        /* eslint-disable-next-line @typescript-eslint/no-use-before-define */
-        const modelRef = parsePath();
-        next(CLOSE_CURL);
-        next(CLOSE_CURL);
-        return modelRef;
-      }
+      next(OPEN_CURL);
+
+      /* eslint-disable-next-line @typescript-eslint/no-use-before-define */
+      const modelRef = parsePath();
+      next(CLOSE_CURL);
+      next(CLOSE_CURL);
+      return modelRef;
     }
   };