Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Efficient Validation #24

Open
KetanReddy opened this issue Jan 12, 2023 · 0 comments
Open

More Efficient Validation #24

KetanReddy opened this issue Jan 12, 2023 · 0 comments
Labels
enhancement New feature or request hacktoberfest minor Increment the minor version when merged XLR Related to XLR Functionality

Comments

@KetanReddy
Copy link
Member

Right now for validation we fill in references, solve generics, generate effective types etc. as we walk through the XLR tree. A more efficient way to do things might be to resolve everything in the SDK before passing it to the validation logic. That would probably simplify some steps in validation related to those more expensive operations and if we cache those computed nodes, speed up subsequent validation calls to the same object. Obviously if new types are loaded in we'll need to invalidate that cache but that probably won't happen too often.

@KetanReddy KetanReddy added enhancement New feature or request minor Increment the minor version when merged XLR Related to XLR Functionality labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest minor Increment the minor version when merged XLR Related to XLR Functionality
Projects
None yet
Development

No branches or pull requests

1 participant