Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete browserDefault.py #3737

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Delete browserDefault.py #3737

wants to merge 2 commits into from

Conversation

gforcada
Copy link
Sponsor Contributor

@gforcada gforcada commented Mar 13, 2023

Seems that this is used only in one template in plone.app.content

@gforcada gforcada marked this pull request as draft March 13, 2023 16:37
@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens
Copy link
Sponsor Member

jensens commented Mar 15, 2023

the usage in plone.app.content can be replaced by is_default_page here https://github.com/plone/plone.base/blob/a6c14baf52cc6f2c41301e662c6d49d4797f3b8e/src/plone/base/defaultpage.py#L100
Anyway, this function is not available in the template, so it needs a function on its view to "proxy" the call.

@gforcada
Copy link
Sponsor Contributor Author

@jenkins-plone-org please run jobs

1 similar comment
@jensens
Copy link
Sponsor Member

jensens commented Feb 19, 2024

@jenkins-plone-org please run jobs

@gforcada
Copy link
Sponsor Contributor Author

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants