fix navtree deprecations #3756
fix navtree deprecations #3756
Conversation
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
jensens
force-pushed
the
fix-navtree-deprecation
branch
from
3b15100
to
ea20ca7
Compare
jensens
force-pushed
the
fix-navtree-deprecation
branch
from
ea20ca7
to
e9c1434
Compare
|
@jenkins-plone-org please run jobs |
|
Can you please split this into one commit with black/isort and one with the interesting changes? That is much easier to review. Now it is not clear at all what the actually interesting changes are. |
|
Well, its using interfaces and utilities from |
Products/CMFPlone/browser/navtree.py
Outdated
| newNode["review_state"] = getattr(item, "review_state", None) | ||
| newNode["Description"] = getattr(item, "Description", None) | ||
| newNode["show_children"] = showChildren | ||
| newNode["no_display"] = False # We sort this out with the nodeFilter | ||
| # BBB getRemoteUrl and link_remote are deprecated, remove in Plone 4 |
There was a problem hiding this comment.
😆 we are a bit late at deprecating these BBB comment 😅
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
jensens
force-pushed
the
fix-navtree-deprecation
branch
from
12782a9
to
99a2bab
Compare
|
@jenkins-plone-org please run jobs |
jensens
changed the title
No description provided.