Cleanup patterns settings #3765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
is this addressing #3633 too? |
This was referenced Apr 11, 2023
… ITinyMCESpellCheckerForm.
petschki
force-pushed
the
cleanup-patterns
branch
from
69ad4b4
to
d98f3ce
Compare
petschki
approved these changes
Jul 17, 2023
|
Does it need an upgrade step to remove existing entries from registry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "After the deadline" plugin, which is dead code.
It removes the relevant code parts without a deprecation warning, which is probably not acceptable.
How should I proceed here? Deprecate it for 6.0 and let it be removed for 6.1? Or should this breaking change to into 7.0?
It's not an urgent issue but would remove some code which is most probably unused.
Together:
#3765
plone/plone.base#33
plone/plone.api#504mergedJenkins:
https://jenkins.plone.org/job/pull-request-6.1-3.11/156/