Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion core addon #3782

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Discussion core addon #3782

wants to merge 14 commits into from

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented May 19, 2023 •
edited

see plone/plone.app.discussion#211 and do not merge alone

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens jensens mentioned this pull request May 19, 2023
Open
@mauritsvanrees
Copy link
Sponsor Member

This could be continued on for Plone 6.1.
The Plone master branch already depends on plone.app.discussion, so that part of turning it into a core add-on is done already.

@mauritsvanrees
Copy link
Sponsor Member

I have just made a release 6.1.0a1 of the Plone package, where plone.app.discussion was added in the requirements, making it a core add-on.
But it is still a requirement of Products.CMFPlone, so not actually a core add-on. :-/. Oh well.
Would be good to continue this draft PR.

@jensens
Copy link
Sponsor Member Author

jensens commented Jan 26, 2024

Indeed, I just had no time to follow up here. Let's see I I can make it happen next 1-2 weeks.

@jensens
Copy link
Sponsor Member Author

jensens commented Jan 26, 2024

@jenkins-plone-org please run jobs

@jensens jensens marked this pull request as ready for review May 20, 2024 18:50
stevepiercy
stevepiercy approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replacing the offensive terms.

davisagli
davisagli approved these changes May 23, 2024
View reviewed changes
news/3782.bugfix Show resolved Hide resolved
@jensens
Copy link
Sponsor Member Author

jensens commented May 23, 2024

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
04 type: enhancement 13 prio: normal 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jensens @mister-roboto @mauritsvanrees @davisagli @stevepiercy