Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Branch: refs/heads/master Date: 2023-03-14T23:55:54+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.i18n@0b756a4 Configuring with plone/meta Files changed: A news/0d0704ce.internal M .meta.toml M .pre-commit-config.yaml M pyproject.toml M setup.cfg M tox.ini Repository: plone.i18n Branch: refs/heads/master Date: 2023-03-14T23:57:01+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.i18n@7cf39d0 git ignore .tox Files changed: M .gitignore Repository: plone.i18n Branch: refs/heads/master Date: 2023-03-15T00:40:34+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.i18n@3886cbe Correctly specified dependencies. `plone.supermodel` and a few others were missing. Fixes plone/plone.i18n#49 Note that in the middle of working on it, I got this from `tox -e dependencies`: ``` Requirements that should be test requirements ============================================= plone.base ``` So I moved `plone.base` from `install_requires` to the `test` extra. Then `z3c.dependencychecker` was happy, saying there were no missing requirements. But this was wrong. Temporarily commenting out `plone.base` in the `test` extra, gave this: ``` INFO: Ignoring package <DottedName plone.base> as is not a dependency of the package being analyzed INFO: Ignoring package <DottedName python-dateutil> as is not a dependency of the package being analyzed Missing requirements ==================== Products.CMFCore.interfaces.IDublinCore Products.CMFCore.interfaces.ISiteRoot Products.CMFCore.utils.registerToolInterface Missing test requirements ========================= Products.CMFCore.interfaces.IDublinCore Products.CMFCore.utils.getToolByName Products.CMFCore.utils.getToolInterface plone.base.interfaces.ILanguage ``` I chose to keep `plone.base` as test extra, and require `Products.CMFCore`. Then `z3c.dependencychecker` is happy again. The alternative is to keep `plone.base` in `install_requires`, but as said: then dependencychecker incorrectly advises that this should be a test requirement. Files changed: A news/49.bugfix M plone/i18n/tests/test_negotiation.py M setup.py D news/0d0704ce.internal Repository: plone.i18n Branch: refs/heads/master Date: 2023-03-15T10:13:02+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.i18n@dcd6cce Merge pull request #51 from plone/config-with-default-template-11bf8094 Fix dependencies Files changed: A news/49.bugfix M .gitignore M .meta.toml M .pre-commit-config.yaml M plone/i18n/tests/test_negotiation.py M pyproject.toml M setup.cfg M setup.py M tox.ini
- Loading branch information