Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to redirect #1244

Open
wants to merge 1 commit into
base: 6.0
Choose a base branch
from
Open

Add option to redirect #1244

wants to merge 1 commit into from

Conversation

wolbernd
Copy link
Contributor

@wolbernd wolbernd commented May 4, 2022

Fixes #1149

@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for 6-dev-docs-plone-org ready!

Name Link
🔨 Latest commit 4b1a68e
🔍 Latest deploy log https://app.netlify.com/sites/6-dev-docs-plone-org/deploys/62725a091d76d80009a1280c
😎 Deploy Preview https://deploy-preview-1244--6-dev-docs-plone-org.netlify.app/contributing/writing-docs-guide.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@wolbernd
Copy link
Contributor Author

wolbernd commented May 4, 2022

@stevepiercy At the moment there is no check if the target of a redirect actually exists, so typos can lead to dead links. It should be possible to create a small script to check this but I'm not sure if this is worth the effort...

@stevepiercy
Copy link
Contributor

How would you implement that small script? Ideally this extension already checks for the existence of the target file before writing the source page. If it does not, then I would consider this a feature request for the extension.

@wolbernd
Copy link
Contributor Author

wolbernd commented May 4, 2022

@stevepiercy The extension does no consistency check for the target documents. An upstream implementation would make sense because every check-script we would write for this project would probably also work for upstream.

I'll open an issue in their gitlab.

@wolbernd
Copy link
Contributor Author

wolbernd commented May 4, 2022

Feature request for sphinx-reredirects: documatt/sphinx-reredirects#3 and open PR documatt/sphinx-reredirects#6.

I'll work on implementing this after the sprint since I think it's a bit out of scope

@stevepiercy stevepiercy changed the base branch from 6-dev to 6.0 January 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Use redirects to avoid link rot with sphinx-reredirects
2 participants