Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BlockDataForm in LeadImage Sidebar #5793

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Manas-Kenge
Copy link

Fixes #5623

Added BlockDataForm in LeadImage Sidebar

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 6b1c7dc
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65ed59542ea5b50009faf5a4

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 6b1c7dc
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65ed5954cee52700088a38e4

@Manas-Kenge
Copy link
Author

Can someone please review this pr?

@stevepiercy
Copy link
Collaborator

@Manas-Kenge pull requests that do not pass checks do not get reviewed. See Test and code quality and Code quality.

],

properties: {
image: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fields in this block do not have this names... also, they are not editables (for now, the sidebar hides them, if not there).
Did you try it and does it match the previous behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LeadImage Sidebar should use BlockDataForm like the rest of the Sidebar files
3 participants