-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slate): fix multiple SlateEditor editing the same field in a form #5813
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto canceled.
|
@sneridagh Looks like this pr fails because of a less file import in unit tests. It seams that the less file is not mocked so probably there is a configuration issue for jest?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvanMiu Why did you change the import to be absolute? We should not do this unless it's a shadow-able module.
The rest LGTM.
@tiberiuichim @ichim-david Can I have a review from you too, please?
closes #5790