-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md add York College to List of sites #5996
base: main
Are you sure you want to change the base?
Conversation
Update README.md add York College to List of sites
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto canceled.
|
@rnunez80 it looks OK now. This PR needs a change log entry. You can add the other website when you add that entry. I don't have any advice for your cache situation. I'd suggest asking on https://community.plone.org/. |
@rnunez80 please could you add the changelog entry? Inside the |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@sneridagh I would not merge this until @rnunez80 adds it to https://github.com/collective/awesome-volto?tab=readme-ov-file#websites-built-with-volto, as we often copy-paste from that section to our README.md, which overwrites whatever was added here. Also @rnunez80 wanted to add a second site. |
In fact, where the contributor promotes their own site in the README, I would prefer to close the PR unless they can follow contributing guidelines. Why should we do their work for them? |
@stevepiercy Only trying to close stale PRs in here. @rnunez80 can you take care of @stevepiercy suggestions? |
@sneridagh sure, but why do their work for them? I would just close this PR. If and when they do things completely, then we can merge it. If it were a feature or bugfix that benefits the project, then that's a different matter. |
Update README.md add York College to List of sites