Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md add York College to List of sites #5996

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rnunez80
Copy link

Update README.md add York College to List of sites

Update README.md add York College to List of sites
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 7719160
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66545819dd594f0008be1a75

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit edb590c
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/66312349141fbe0008fdda09

README.md Outdated Show resolved Hide resolved
@rnunez80
Copy link
Author

rnunez80 commented Apr 30, 2024 via email

@stevepiercy
Copy link
Collaborator

@rnunez80 it looks OK now.

This PR needs a change log entry. You can add the other website when you add that entry.

I don't have any advice for your cache situation. I'd suggest asking on https://community.plone.org/.

@sneridagh
Copy link
Member

sneridagh commented May 6, 2024

@rnunez80 please could you add the changelog entry? Inside the packages/volto/news is the right place in this case.

@stevepiercy
Copy link
Collaborator

@sneridagh I would not merge this until @rnunez80 adds it to https://github.com/collective/awesome-volto?tab=readme-ov-file#websites-built-with-volto, as we often copy-paste from that section to our README.md, which overwrites whatever was added here. Also @rnunez80 wanted to add a second site.

@stevepiercy
Copy link
Collaborator

In fact, where the contributor promotes their own site in the README, I would prefer to close the PR unless they can follow contributing guidelines. Why should we do their work for them?

@sneridagh
Copy link
Member

@stevepiercy Only trying to close stale PRs in here. @rnunez80 can you take care of @stevepiercy suggestions?

@stevepiercy
Copy link
Collaborator

@sneridagh sure, but why do their work for them? I would just close this PR. If and when they do things completely, then we can merge it.

If it were a feature or bugfix that benefits the project, then that's a different matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants