This repository has been archived by the owner on Apr 26, 2022. It is now read-only.
Inquirer function params #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to better honour the `inquirer` function contract for `question.filter` and `question.validate`.
|
The code/tests look good here! Admittedly, though, I'm still not sure what this change means for consumers of |
Ensure the `answers` object is also passed to the `filter` function.
RobinKnipe
force-pushed
the
inquirer-function-params
branch
from
b0204f3
to
30e08d4
Compare
Ensure the `answers` object is also passed to the `validate` function.
|
Hi @crutchcorn - I think your reply was quicker than the circle-ci tests (which I've fixed)! I've also added a similar test to check the validate function receives the answers hash too. The inquirer function definitions can be found here FYR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #189
Call the
inquirerfunctions with the expectedanswershash parameter.