fix: inherit config #394
Open
fix: inherit config #394
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moltar
commented
Sep 4, 2023
moltar
commented
Sep 4, 2023
| @@ -173,4 +173,15 @@ describe("load-assets-from-plopfile", function () { | |||
| expect(plop.getPartialList().length).toBe(1); | |||
| expect(plop.getPartialList()[0]).toBe("p1"); | |||
| }); | |||
|
|
|||
| test.todo("plop.load loaded plopfile inherits config", async function () { | |||
crutchcorn
requested changes
Sep 4, 2023
Comment on lines
177
to
186
| test.todo("plop.load loaded plopfile inherits config", async function () { | ||
| const plop = await nodePlop("", { | ||
| force: true, | ||
| }); | ||
|
|
||
| await plop.load(plopfilePath, null, {}); | ||
|
|
||
| // not a working test | ||
| expect(plop.config.force).toBe(true); | ||
| }); |
There was a problem hiding this comment.
Instead of a TODO test, let's add an e2e test using Plop CLI :)
There was a problem hiding this comment.
e2e test using Plop CLI
Is there a prior art for this?
Can't find anything like that in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass configuration from main plop to loaded plops.
Did not add tests, as I could not find anywhere to hook into to check the config values. Config is not exposed directly and doesn't seem to be exposed indirectly either. But I added a stub test, in case you know where to hook into and want to fix this quickly, or let me know and I can add another commit for the test.
Closes: #392