Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate InvalidCallbackReturnValue size #2663

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

stdedos
Copy link

@stdedos stdedos commented Oct 12, 2023

Truncate the stringified value of bad_val,
in order to avoid excessive output on the debug pop-up.

Fixes #2658

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

@stdedos stdedos force-pushed the fix/2658/truncate-InvalidCallbackReturnValue-obj branch from 5f28a34 to ea238d2 Compare October 12, 2023 12:27
@alexcjohnson
Copy link
Collaborator

Looks great, thanks! Would you mind adding a test in test_devtools_error_handling, perhaps modeled off dveh003, where a callback returns a very long value that gets truncated? (No need for the percy snapshot though, just validate the contents of the error

After that, just a changelog entry - make a new ## Unreleased -> ## Fixed section at the top if necessary.

@Coding-with-Adam
Copy link

hi @stdedos
Thank you for creating this pull request. We wanted to follow up and encourage you to finalize this PR by adding a test. In case it's helpful, here is an example of a basic Dash test.

Truncate the stringified value of `bad_val`,
in order to avoid excessive output on the debug pop-up.

Fixes plotly#2658

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@stdedos stdedos force-pushed the fix/2658/truncate-InvalidCallbackReturnValue-obj branch 3 times, most recently from 3a3bc5d to 9940d50 Compare November 13, 2023 13:58
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@stdedos stdedos force-pushed the fix/2658/truncate-InvalidCallbackReturnValue-obj branch from 9940d50 to 587fa9d Compare November 13, 2023 14:15
@stdedos
Copy link
Author

stdedos commented Nov 14, 2023

Hello there, both!

I don't think it's feasible for me to do testing for this PR.

It was not a commitment discussed in #2658.
Furthermore, testing dash is problematic for me from start to finish 😓

  1. Local testing is impossible to start
  2. I cannot find good instructions
  3. REPL via CI is too slow

I do not want to spend more headaches trying to bootstrap testing something otherwise easy to spot as working.

@alexcjohnson
Copy link
Collaborator

Thanks for giving it a shot @stdedos - sorry to hear it's not working. We'll find a time to finish it up at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate InvalidCallbackReturnValue size?
3 participants