Adding support for bringing your own driver to the Browser #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dash/testing/browser.py
Outdated
| self._driver = driver | ||
| else: | ||
| self._driver = until(self.get_webdriver, timeout=1) | ||
| self._driver.implicitly_wait(2) |
There was a problem hiding this comment.
Do we want the implicitly_wait inside here or would it be better to always call that even if you provide your own driver?
There was a problem hiding this comment.
Lets set the implicitly_wait(2) for all, since there is no easy way to confirm if the driver already has one set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept of being able to bring your own driver to the Browser object of dash.testing and be able to utilize predefined dash_duo tests.
Looking for feedback and usability.