Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clustering options to scattermapbox #5827

Merged
merged 23 commits into from Oct 14, 2022
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 14, 2021

Follow up for PR #5334.

Options added by @elben10 to enable mapbox clustering layer.
Please note that currently it doesn't support the fill, selection and text features.

Some remaining TODOs:

  • add jasmine tests to ensure Plotly.react can switch between modes i.e. with/without cluster
  • add second mock & baseline using new attributes e.g. step and opacity

@plotly/plotly_js

cluster: {
enabled: {
valType: 'boolean',
dflt: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a smart default here? ie true if any other cluster attributes are set, otherwise false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Done in 477d2a0.

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants