Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choroplethmapbox update on select #6345

Merged
merged 5 commits into from Oct 21, 2022
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 20, 2022

Fixes #6346
cc: plotly/dash#1097

@celia-plotly I appreciate it if one could test this plotly.js build in a dash app.

@plotly/plotly_js

@alexcjohnson
Copy link
Contributor

@archmoj using your new bundle (and the updated app plotly/dash#1097 (comment)) I don't see any console errors, but I also (after clicking the button any number of times) don't the deselected points dim.

@alexcjohnson
Copy link
Contributor

Nice and simple! Can we create a test based on your reproduction in #6346?

@archmoj
Copy link
Contributor Author

archmoj commented Oct 21, 2022

Nice and simple! Can we create a test based on your reproduction in #6346?

Done in 464718c.

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good!

@archmoj archmoj merged commit dacaa59 into master Oct 21, 2022
@archmoj archmoj deleted the choroplethmapbox-updateOnSelect branch October 21, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection broken after reacting add another trace on top of choroplethmapbox
2 participants