New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed hover behaviour for multicategory plots #6360

Merged

archmoj merged 15 commits into plotly:master from VictorBezak:fixed_multicategory_hover

Nov 16, 2022

Contributor

filipesantiagoAM commented Nov 4, 2022 •

edited by archmoj

The issue

Fixes #6331

How to test

Use the mock multicategory_series.json.

Please let me know if you would like to have tests written about this fix.

Current behaviour

Thanks.

@alexcjohnson @archmoj

filipesantiagoAM added 2 commits

November 4, 2022 23:42


          Fixed hover behaviour for multicategory plots

7157b54


          Fix legend group for vCar line

7ff8cee

archmoj added type: bug type: community status: reviewable labels

archmoj reviewed

View reviewed changes

test/image/mocks/multicategory_series.json Outdated Show resolved Hide resolved

archmoj added the status: has TODOs label


          Simplify mock and added jasmine test

ce0527e

archmoj reviewed

View reviewed changes

test/image/mocks/multicategory_series.json Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

test/image/mocks/multicategory_series.json Outdated Show resolved Hide resolved

filipesantiagoAM added 3 commits

November 14, 2022 16:52


          Remove legend y auto

0e7c667


          Rename multicategory to z-multicategory mock

7c8cf32


          Rename to zz-multicategory_series.json

9f39bb8

Contributor

archmoj commented Nov 14, 2022

For each new mock we need to have a new baseline.
Please download the png from the address below and then place it in test/image/baseline folder. Thanks!
https://app.circleci.com/pipelines/github/plotly/plotly.js/7668/workflows/5b0cc5d4-05ba-4a06-b21c-0badf510aaa3/jobs/171780/artifacts

archmoj reviewed

View reviewed changes

test/image/mocks/zz-multicategory_series.json Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

test/jasmine/tests/hover_label_test.js Outdated Show resolved Hide resolved

filipesantiagoAM added 2 commits

November 14, 2022 17:29


          Fix test errors

f2f9dd8


          Fix test name

48c872b

archmoj reviewed

View reviewed changes

test/jasmine/tests/hover_label_test.js Show resolved Hide resolved

filipesantiagoAM added 2 commits

November 14, 2022 19:01


          Fix tests for multicategory hover

0c0eace


          Removed fit test

073650c

filipesantiagoAM force-pushed the fixed_multicategory_hover branch from 8a0c2a8 to 073650c Compare

November 14, 2022 20:47

filipesantiagoAM added 2 commits

November 14, 2022 20:48


          Try new mock title

4e04878


          Reverted new mock title

5aa216b

Contributor Author

filipesantiagoAM commented Nov 14, 2022

@archmoj All good here. Thanks

archmoj removed the status: has TODOs label

archmoj reviewed

View reviewed changes

src/components/fx/hover.js Outdated Show resolved Hide resolved


          Update src/components/fx/hover.js

745afcc

Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>

archmoj reviewed

View reviewed changes

src/components/fx/hover.js Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

src/components/fx/hover.js Outdated Show resolved Hide resolved


          Improve get hover label multicategory

1bd56af

archmoj reviewed

View reviewed changes

src/components/fx/hover.js Outdated Show resolved Hide resolved


          Simplify variable on hover

5d83a4d

Contributor

archmoj commented Nov 16, 2022

💃
Nicely done 🥇

This fix would be available in v2.16.3 shortly.
Thank you!

archmoj merged commit 6c6937b into plotly:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment