Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked grouped bar chart #4486

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RenaudLN
Copy link

@RenaudLN RenaudLN commented Jan 20, 2024

What's new

Adds a new figure factory for grouped stacked bar charts

import plotly.express as px
import plotly.figure_factory as ff

df = px.data.tips().groupby(["day", "sex", "smoker"])[["total_bill", "tip"]].sum().reset_index()

fig = ff.create_grouped_stacked_bar(
    df,
    x="smoker",
    stack_group="sex",
    color="day",
    y="tip",
    category_orders={"day": ["Thur", "Fri", "Sat", "Sun"]},
)
fig.show()

image

import plotly.express as px
import plotly.figure_factory as ff

df = px.data.tips().groupby(["day", "sex", "smoker"])[["total_bill", "tip"]].sum().reset_index()

fig = ff.create_grouped_stacked_bar(
    df,
    x="sex",
    stack_group="day",
    color="smoker",
    y="tip",
    category_orders={"day": ["Thur", "Fri", "Sat", "Sun"]},
    template="seaborn",
    stack_group_gap=0.33,
    bar_gap=0.02,
)
fig.show()

image

Issues: #2976 #3251

Documentation PR

  • I've seen the doc/README.md file
  • This change runs in the current version of Plotly on PyPI and targets the doc-prod branch OR it targets the master branch
  • If this PR modifies the first example in a page or adds a new one, it is a px example if at all possible
  • Every new/modified example has a descriptive title and motivating sentence or paragraph
  • Every new/modified example is independently runnable
  • Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • The random seed is set if using randomly-generated data in new/modified examples
  • New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
  • Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • Imports are plotly.graph_objects as go / plotly.express as px / plotly.io as pio
  • Data frames are always called df
  • fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
  • Liberal use is made of fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters like fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
  • fig.show() is at the end of each new/modified example
  • plotly.plot() and plotly.iplot() are not used in any new/modified example
  • Hex codes for colors are not used in any new/modified example in favour of these nice ones

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@alexcjohnson
Copy link
Collaborator

Thanks @RenaudLN! This functionality is fantastic. My hesitation though is that we really want this built into plotly.js, and I think we have most of the pieces in place to make that happen, so it shouldn't be very hard to finish. It would be confusing if we add this and soon after create a different and preferred way to do the same thing.

@archmoj can you look into what more we need to add for plotly.js to create stacked grouped bars natively?

@RenaudLN
Copy link
Author

RenaudLN commented Feb 10, 2024

Hey @alexcjohnson I agree it would be best to support this natively but it's already been open for 4 years 🙂 plotly/plotly.js#4914

There is a way to do stacked-grouped bars currently but it requires setting the x-axis (for vertical bars) as array of arrays which can make the axis very crowded (I'm thinking timeseries for instance). Also there is no way to control the spacing between groups with this method.
image

Compared to this
image

Something I would love to see if you do implement it natively is automatically declining the base colorscale colors within each stack (each stack is assigned a color from the colorscale then varied on the lightness scale for the components of the stack).

@RenaudLN
Copy link
Author

RenaudLN commented Apr 8, 2024

Any update on this?

@archmoj
Copy link
Contributor

archmoj commented Apr 8, 2024

Any update on this?

Hi @RenaudLN
I still need to investigate possibility of implementing this in plotly.js.
I could start looking into that (in few days) right after next plotly.js minor is out.
Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants