fix: use "==" with literal to remove warning during "python setup.py updateplotlyjs" #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updateplotlyjs"
- Existing code produces this warning during `python setup.py updateplotlyjs` step from `contributing.md`:
```
/Users/gvwilson/plotly.py/packages/python/chart-studio/chart_studio/tools.py:290: SyntaxWarning: "is" with a literal. Did you mean "=="?
if share_key is "":
```
- Revised code uses `==` instead of `is`
- Warning goes away
- No change in test status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python setup.py updateplotlyjsstep fromcontributing.md:Revised code uses
==instead ofisI have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.