Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - fixedShaped funnel with customizable neck height/width #2334

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bdknox
Copy link

@bdknox bdknox commented May 9, 2023

feat(funnel) - Option to make the funnel chart a fixed shape with customizable neck width/height to more directly resemble a funnel shape.

Three new props for Funnel:

  1. fixedShape: boolean
  2. neckHeightRatio: number - only applicable when fixedShape is true
  3. neckWidthRatio: number - only applicable when fixedShape is true
fixedShape.funnel.demo.mov

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 11:34pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ee6352:

Sandbox Source
nivo Configuration

@plouc
Copy link
Owner

plouc commented May 10, 2023

The feature can be previewed here.

@plouc
Copy link
Owner

plouc commented May 10, 2023

@bdknox, I haven't reviewed the PR yet, but looking at the website preview, it seems like borders don't work anymore.

@bdknox
Copy link
Author

bdknox commented May 10, 2023

Sorry about that @plouc, I meant to mention that in the PR description and have some documentation on it. I left it without supporting the borders for now because of how borders are currently implemented and how it looks with this shape of the funnel. They clip into the previous parts as seen below. I can look into it if you'd prefer for borders to be supported for this format as well. Otherwise I'll add some info to the PR description and the website info under the fixedShape input

Screenshot 2023-05-09 at 11 12 41 PM

@stale stale bot added the stale label Aug 10, 2023
@plouc plouc added pinned and removed stale labels Aug 13, 2023
Repository owner deleted a comment from stale bot Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants