Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line package TypeScript migration #2485

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Line package TypeScript migration #2485

wants to merge 4 commits into from

Conversation

plouc
Copy link
Owner

@plouc plouc commented Dec 4, 2023

  • Migrate @nivo/line to typescript
  • Remove prop-types
  • Define defaults without using defaultProps
  • Fix unit tests to use react-test-renderer instead of enzyme
  • Fix getInheritedColorGenerator return type in @nivo/colors
  • Use readonly when appropriate for @nivo/line properties
  • Use readonly for markers in @nivo/core
  • Use readonly for data in @nivo/legends
  • Use readonly for points in @nivo/voronoi

@plouc plouc self-assigned this Dec 4, 2023
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ❌ Failed (Inspect) Dec 5, 2023 9:36pm

@plouc plouc added 📈 line @nivo/line package typescript labels Dec 4, 2023
@plouc plouc added this to In progress in TypeScript migration Dec 4, 2023
Copy link

stale bot commented Mar 13, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant