Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sankey): update onClick types in sankey chart to respect generics #2509

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(sankey): update onClick types in sankey chart to respect generics #2509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9207d86
Fix onClick types in sankey chart
stas-demydiuk Feb 3, 2024
b0a2406
Update types.ts
stas-demydiuk Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sankey/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export interface SankeyDataProps<N extends DefaultNode, L extends DefaultLink> {

export type SankeyLayerId = 'links' | 'nodes' | 'labels' | 'legends'

export type SankeyMouseHandler = <N extends DefaultNode, L extends DefaultLink>(
export type SankeyMouseHandler<N extends DefaultNode, L extends DefaultLink> = (
data: SankeyNodeDatum<N, L> | SankeyLinkDatum<N, L>,
event: MouseEvent
) => void
Expand Down Expand Up @@ -142,7 +142,7 @@ export interface SankeyCommonProps<N extends DefaultNode, L extends DefaultLink>
labelTextColor: InheritedColorConfig<SankeyNodeDatum<N, L>>

isInteractive: boolean
onClick: SankeyMouseHandler
onClick: SankeyMouseHandler<N, L>
nodeTooltip: FunctionComponent<{ node: SankeyNodeDatum<N, L> }>
linkTooltip: FunctionComponent<{ link: SankeyLinkDatum<N, L> }>

Expand Down