Rewrite componentId to support react17 #2545
Merged
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a7b972:
|
|
@plouc , would be great if this could be merged and released. |
|
Thanks for the PR, waiting for this to land |
|
Hello! When will we be able to enjoy these changes? Thanks! |
|
Thank you for the fix @Alex-Spike! |
Closed
|
Thank you for pushing these changes into the package @plouc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite componentId to support react17
Issue: #2536
I fully understand the benefits of react useId hook but it doesn't work for react 17. As in new versions this lib resolved all vulnerabilities issues it will be great to support react 17 as well. I’ve just rewritten it to "lodash/uniqueId" and then it can be supported for all versions.
Thank you