feat: added option to download zip #94
Open
+93
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boazpoolman
requested changes
Jun 19, 2023
| const fullFilePath = `${strapi.config.get('plugin.config-sync.syncDir')}${fileName}` | ||
| const stats = fs.statSync(fullFilePath); | ||
|
|
||
| const result = await strapi.plugins.upload.services.upload.upload({ |
There was a problem hiding this comment.
Uploading through the upload plugin makes the zip file publically accessible.
That would be a security risk as there may be sensitive data in the /config/sync directory.
Is there a way we can download the zip from memory, instead of writing it to the disk first?
|
Hi everyone, any updates ?) |
|
This feature is not a priority for me right now. I've put some feedback on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Allow to download a zip of all config files
Why is it needed?
Accessing remote configs
How to test it?
Related issue(s)/PR(s)
Closes #54