Updated the restoreCase logic to check for upper and lower case pluralization

[lappang-cheung]

I'd updated the logic for the restoreCase as it has missed some testcases as well and it shall pass for the new ones. And this is the solution for https://github.com/blakeembrey/pluralize/issues/131

it('should allow new plural matching rules', function () {
      expect(pluralize.plural('vIP')).to.equal('vIPS');

      pluralize.addPluralRule(/vIvP$/i, 'vIvPs');

      expect(pluralize.plural('vIvP')).to.equal('vIvPs');
    });

    it('should allow new plural matching rules', function () {
      expect(pluralize.plural('IP')).to.equal('IPS');

      pluralize.addPluralRule(/IP$/i, 'IPs');

      expect(pluralize.plural('IP')).to.equal('IPs');
    });

    it('should allow new plural matching rules', function () {
      expect(pluralize.plural('Blank Application2')).to.equal('Blank Application2s');

      pluralize.addPluralRule(/tion2$/i, 'tion2S');

      expect(pluralize.plural('Blank Application2')).to.equal('Blank Application2S');
    });

[coveralls]

Coverage remained the same at 100.0% when pulling 896313f on lappang-cheung:features/restoreCaseLogicUpdate into abb3991 on blakeembrey:master.

[blakeembrey]

This is a breaking change for supported environments of pluralize. We should change startsWith to something else. Can you also remove the token logic below? This probably overlaps in implementation.

[lappang-cheung]

Updated the code with:

if ((token.toLowerCase().substring(0, word.length)) === word.toLowerCase()) {
      return word + token.substring(word.length);
    }

These parts only check for special cases where we have weird combinations when calling the "pluralize" method and if this check fails then it goes to the base case. Such as "sTaRTREK" and wanting the result to be "sTaRTREKS".

[blakeembrey]

Please don't change this.

[lappang-cheung]

Hey Blake,

I'd undid the changes to the ".gitignore" file and updated the "pluralize" file.

As for my logic:

// This is an unique case, where we try to preserved the words that aren't changed significantly.
    // E.g. "sTaRTREK" (plural form is sTaRTREKs).
    if ((token.toLowerCase().substring(0, word.length)) === word.toLowerCase()) {
      return word + token.substring(word.length);
    }

    // Lower cased words. E.g. "hello".
    if (word === word.toLowerCase()) return token.toLowerCase();

    // Upper cased words. E.g. "WHISKY".
    if (word === word.toUpperCase()) return token.toUpperCase();

This parts only check for special cases where we have weird combination when calling "pluralize" method and if this checks fails then it goes to the base case. Such as "sTaRTREK" and wanting the result to be "sTaRTREKS".

[blakeembrey]

I’d like to see more tests and unnecessary changes reverted before I can merge it. Based on this PR, I’m pretty sure it’ll break anyone using upper cased words. At that point, it’s probably better to just always use lowercase and not have this logic at all.

[blakeembrey]

Actually, am I understanding this correctly that it'll only word if the entire token is matched? In that case, I think it'd be better that we find a more appropriate solution. It also doesn't solve #131 unless you intend to add manual overrides to every word, which seems redundant.

[blakeembrey]

If this is a real issue for people, I propose just removing the feature altogether and making the consumers of the library handle the casing they want. It'd make it slightly faster, make those overrides "expected", and making it to upper case is easier than doing all the other magic.

[blakeembrey]

Here's a test case to consider that fails with this change, if you're planning to add more tests:

> pluralize.plural('SCHEMA')
'SCHEMAta'