Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] update for R3F v9 #1941

Open
wants to merge 11 commits into
base: v10
Choose a base branch
from
Open

[feat] update for R3F v9 #1941

wants to merge 11 commits into from

Conversation

krispya
Copy link
Member

@krispya krispya commented Apr 29, 2024 •
edited

This is untested. It is a quick conversion of Drei v9 to use R3F v9 without any typing errors.

@krispya
Update for v9
0d9864e
@krispya
Update for latest R3F v9 alpha
916c369
@krispya
Merge branch 'master' into v10
faf1a66 
# Conflicts:
#	src/core/Environment.tsx
#	src/core/useEnvironment.tsx
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:40pm

@krispya
Copy link
Member Author

krispya commented Apr 29, 2024

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

@CodyJasonBennett CodyJasonBennett mentioned this pull request May 1, 2024
Closed
3 tasks
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 8, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@krispya
Copy link
Member Author

krispya commented May 8, 2024

Now builds. Known issues are with components that access R3F internals like RenderTexture.

@joshuaellis
Copy link
Member

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha

@krispya
Copy link
Member Author

krispya commented May 8, 2024

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha

I believe it is just types, maybe related to this: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript

We also moved types for R3F to ThreeElements.

@krispya krispya changed the base branch from master to v10 May 19, 2024 01:50
@krispya
Merge branch 'master' into v10
512d642 
# Conflicts:
#	src/core/Text.tsx
CodyJasonBennett
CodyJasonBennett reviewed May 20, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@krispya @CodyJasonBennett
Update package.json
e64c631 
Co-authored-by: Cody Bennett <hi@codyb.co>
@krispya
Copy link
Member Author

krispya commented May 21, 2024

@CodyJasonBennett I'm stuck again getting the test to run. Some kind of source map issue.

CodyJasonBennett
CodyJasonBennett reviewed May 22, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@krispya @CodyJasonBennett
Update package.json
d8b3ed3 
Co-authored-by: Cody Bennett <hi@codyb.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodyJasonBennett CodyJasonBennett CodyJasonBennett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krispya @joshuaellis @CodyJasonBennett