-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(build): drop module condition in exports #1675
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
what do you think? @barelyhuman |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b2e680d:
|
Size Change: -12.1 kB (-16%) 👏 Total Size: 63.3 kB
ℹ️ View Unchanged
|
This was added for snowpack if I remember properly, since it didn't pick up the |
Confirmed, |
Checking #1756 if this is related. |
"module" condition was added for non-native ESM to possibly support old bundlers.
Not sure, if/how it's used. Maybe, it was added for webpack 4, but not required for v2.