Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update typescript.mdx #1701

Merged
merged 2 commits into from
Jan 20, 2023
Merged

fix(docs): Update typescript.mdx #1701

merged 2 commits into from
Jan 20, 2023

Conversation

meotimdihia
Copy link
Contributor

@meotimdihia meotimdihia commented Jan 19, 2023

Add an example about the case access to the return type

Related Issues

#1699

Summary

Add an example about the case access to the return type

Check List

  • yarn run prettier for formatting code and docs

Add an example about the case access to the return type
@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
jotai ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 1:47PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c513c82:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. Looks good other than one comment.

const [num, setNum] = useAtom(primitiveNumAtom)
const [num] = useAtom(readOnlyNumAtom)
const [, setNum] = useAtom(writeOnlyNumAtom)
```

### Access to the return type of an atom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be more consistent wording.

Suggested change
### Access to the return type of an atom
### Access to the value type of an atom

Fixed words and the format with prettier
@dai-shi dai-shi changed the title Update typescript.mdx fix(docs): Update typescript.mdx Jan 20, 2023
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@dai-shi dai-shi merged commit 905b883 into pmndrs:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants