-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update preset section on spring config #1999
docs: Update preset section on spring config #1999
Conversation
|
@heyfirst is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0152bd9:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, i'm wondering if we should combine the preset visualiser and the config editor, do you see any value in keeping them separate?
## Config Visualizer | ||
|
||
```jsx live=true template=configPlayground showCode=false | ||
import { useRef, useState } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useState isn't being used, I think we should remove this.
@joshuaellis Good point! I didn't see any value to separate it either. I will update to add one more preset option to the config visualizer above. Will ping you once it's ready to review :) |
Sorry for super-long silence, I have been into some initiatives on my current work, many things to catchup, I will update this PR on this weekend. |
closing due to inactivity |
Why
I see a lot of value from this preset section in old docs. I believe it would be nice if we can have similar thing in new docs as well.
What
Checklist
Comments
Here is my first time coding in remix and
jsx
tag on MDX. It is really cool that we can define a code on MDX and automatically run on codesandbox. That's brilliant!