Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update preset section on spring config #1999

Conversation

heyfirst
Copy link
Contributor

@heyfirst heyfirst commented Oct 15, 2022

Why

I see a lot of value from this preset section in old docs. I believe it would be nice if we can have similar thing in new docs as well.

What

  • Move preset section to be under the config visualization
  • Add preset visualization with the same idea of original preset section

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

Comments

Here is my first time coding in remix and jsx tag on MDX. It is really cool that we can define a code on MDX and automatically run on codesandbox. That's brilliant!

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2022

⚠️ No Changeset found

Latest commit: 0152bd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2022

@heyfirst is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-spring-beta ✅ Ready (Inspect) Visit Preview Oct 15, 2022 at 0:24AM (UTC)
react-spring-io ❌ Failed (Inspect) Oct 15, 2022 at 0:24AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0152bd9:

Sandbox Source
spring-animating-auto Configuration
spring-card Configuration
spring-cards-stack Configuration
spring-chain Configuration
spring-css-keyframes Configuration
spring-draggable-list Configuration
spring-exit-before-enter Configuration
spring-flip-card Configuration
spring-goo-blobs Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-multistage-transition Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-simple-transition Configuration
spring-svg-filter Configuration
spring-slide Configuration
spring-tree Configuration
spring-viewpager Configuration

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, i'm wondering if we should combine the preset visualiser and the config editor, do you see any value in keeping them separate?

## Config Visualizer

```jsx live=true template=configPlayground showCode=false
import { useRef, useState } from 'react'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useState isn't being used, I think we should remove this.

@heyfirst
Copy link
Contributor Author

@joshuaellis Good point! I didn't see any value to separate it either. I will update to add one more preset option to the config visualizer above. Will ping you once it's ready to review :)

@heyfirst
Copy link
Contributor Author

Sorry for super-long silence, I have been into some initiatives on my current work, many things to catchup, I will update this PR on this weekend.

@joshuaellis joshuaellis changed the base branch from old-docs to main February 28, 2023 17:34
@joshuaellis
Copy link
Member

closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants