Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bouncing ball react-spring example #2222

Closed
wants to merge 2 commits into from

Conversation

Misterlinux
Copy link

@Misterlinux Misterlinux commented Nov 20, 2023

Why

Adding a demo for the react-spring controller section

What

Added a Codesandbox Demo to the react-spring examples.

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

Feel free to message me in case any edit is needed to my code

Adding the example to the React-Spring sandboxes
Adding bouncing ball example to the sandboxes.ts
Copy link

changeset-bot bot commented Nov 20, 2023

⚠️ No Changeset found

Latest commit: 7dcd1be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 10:32am

@joshuaellis
Copy link
Member

This example appears to use non-english variable names and uses bootstrap-css which isn't something we really feel the need to advocate in addition it's not up to a standard I would expect e.g. not using jsx files and using @react-spring/animated directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants