-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: play nice with OffscreenCanvas #2770
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df7e30e:
|
* | ||
* @todo before releasing next major version (v9), re-order arguments here to width, height, top, left, updateStyle | ||
*/ | ||
setSize: (width: number, height: number, updateStyle?: boolean, top?: number, left?: number) => void | ||
setSize: ( | ||
width: number, | ||
height: number, | ||
/** @deprecated `updateStyle` is now disabled for OffscreenCanvas and will be removed in v9. */ | ||
updateStyle?: boolean, | ||
top?: number, | ||
left?: number, | ||
) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider an overload for this for the setSize(width, height, top, left)
signature by checking if updateStyle
is a number and if top
is defined but not left
.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) | [`8.11.2` -> `8.11.5`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.2/8.11.5) | [![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/compatibility-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/confidence-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.11.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.5) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.4...v8.11.5) #### What's Changed - fix(types): update canvas root types by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2774 **Full Changelog**: pmndrs/react-three-fiber@v8.11.4...v8.11.5 ### [`v8.11.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.4) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.3...v8.11.4) #### What's Changed - fix: play nice with OffscreenCanvas by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2770 - fix: use width and height from OffscreenCanvas by [@​ulyssesdotcodes](https://togithub.com/ulyssesdotcodes) in [pmndrs/react-three-fiber#2773 **Full Changelog**: pmndrs/react-three-fiber@v8.11.3...v8.11.4 ### [`v8.11.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.3) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.2...v8.11.3) #### What's Changed - fix(core): set THREE.ColorManagement.enabled if able by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2620 - chore(docs): update documentation on re-using materials by [@​Coada](https://togithub.com/Coada) in [pmndrs/react-three-fiber#2711 #### New Contributors - [@​Coada](https://togithub.com/Coada) made their first contribution in [pmndrs/react-three-fiber#2711 - [@​enijar](https://togithub.com/enijar) made their first contribution in [pmndrs/react-three-fiber#2772 **Full Changelog**: pmndrs/react-three-fiber@v8.11.2...v8.11.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) | [`8.11.2` -> `8.11.5`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.2/8.11.5) | [![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/compatibility-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/confidence-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.11.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.5) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.4...v8.11.5) #### What's Changed - fix(types): update canvas root types by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2774 **Full Changelog**: pmndrs/react-three-fiber@v8.11.4...v8.11.5 ### [`v8.11.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.4) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.3...v8.11.4) #### What's Changed - fix: play nice with OffscreenCanvas by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2770 - fix: use width and height from OffscreenCanvas by [@​ulyssesdotcodes](https://togithub.com/ulyssesdotcodes) in [pmndrs/react-three-fiber#2773 **Full Changelog**: pmndrs/react-three-fiber@v8.11.3...v8.11.4 ### [`v8.11.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.3) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.2...v8.11.3) #### What's Changed - fix(core): set THREE.ColorManagement.enabled if able by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2620 - chore(docs): update documentation on re-using materials by [@​Coada](https://togithub.com/Coada) in [pmndrs/react-three-fiber#2711 #### New Contributors - [@​Coada](https://togithub.com/Coada) made their first contribution in [pmndrs/react-three-fiber#2711 - [@​enijar](https://togithub.com/enijar) made their first contribution in [pmndrs/react-three-fiber#2772 **Full Changelog**: pmndrs/react-three-fiber@v8.11.2...v8.11.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes #2765