Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: play nice with OffscreenCanvas #2770

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Conversation

CodyJasonBennett
Copy link
Member

Fixes #2765

import * as THREE from 'three'
import { extend, createRoot } from '@react-three/fiber'

const canvas = document.createElement('canvas')
document.body.appendChild(canvas)

const offscreen = canvas.transferControlToOffscreen()

extend(THREE)

createRoot(offscreen).render(<gridHelper onBeforeRender={console.log} />)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df7e30e:

Sandbox Source
example Configuration

Comment on lines -138 to +153
*
* @todo before releasing next major version (v9), re-order arguments here to width, height, top, left, updateStyle
*/
setSize: (width: number, height: number, updateStyle?: boolean, top?: number, left?: number) => void
setSize: (
width: number,
height: number,
/** @deprecated `updateStyle` is now disabled for OffscreenCanvas and will be removed in v9. */
updateStyle?: boolean,
top?: number,
left?: number,
) => void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider an overload for this for the setSize(width, height, top, left) signature by checking if updateStyle is a number and if top is defined but not left.

@CodyJasonBennett CodyJasonBennett merged commit 9340ec4 into master Feb 23, 2023
@CodyJasonBennett CodyJasonBennett deleted the fix/offscreencanvas branch February 23, 2023 15:37
renovate bot added a commit to ziyadedher/ziyadedher that referenced this pull request Feb 23, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.11.2` ->
`8.11.5`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.2/8.11.5)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/compatibility-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/confidence-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.11.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.5)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.4...v8.11.5)

#### What's Changed

- fix(types): update canvas root types by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2774

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.4...v8.11.5

###
[`v8.11.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.4)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.3...v8.11.4)

#### What's Changed

- fix: play nice with OffscreenCanvas by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2770
- fix: use width and height from OffscreenCanvas by
[@&#8203;ulyssesdotcodes](https://togithub.com/ulyssesdotcodes) in
[pmndrs/react-three-fiber#2773

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.3...v8.11.4

###
[`v8.11.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.3)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.2...v8.11.3)

#### What's Changed

- fix(core): set THREE.ColorManagement.enabled if able by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2620
- chore(docs): update documentation on re-using materials by
[@&#8203;Coada](https://togithub.com/Coada) in
[pmndrs/react-three-fiber#2711

#### New Contributors

- [@&#8203;Coada](https://togithub.com/Coada) made their first
contribution in
[pmndrs/react-three-fiber#2711
- [@&#8203;enijar](https://togithub.com/enijar) made their first
contribution in
[pmndrs/react-three-fiber#2772

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.2...v8.11.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ziyadedher pushed a commit to ziyadedher/ziyadedher that referenced this pull request Dec 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.11.2` ->
`8.11.5`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.2/8.11.5)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/compatibility-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.5/confidence-slim/8.11.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.11.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.5)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.4...v8.11.5)

#### What's Changed

- fix(types): update canvas root types by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2774

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.4...v8.11.5

###
[`v8.11.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.4)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.3...v8.11.4)

#### What's Changed

- fix: play nice with OffscreenCanvas by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2770
- fix: use width and height from OffscreenCanvas by
[@&#8203;ulyssesdotcodes](https://togithub.com/ulyssesdotcodes) in
[pmndrs/react-three-fiber#2773

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.3...v8.11.4

###
[`v8.11.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.3)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.2...v8.11.3)

#### What's Changed

- fix(core): set THREE.ColorManagement.enabled if able by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2620
- chore(docs): update documentation on re-using materials by
[@&#8203;Coada](https://togithub.com/Coada) in
[pmndrs/react-three-fiber#2711

#### New Contributors

- [@&#8203;Coada](https://togithub.com/Coada) made their first
contribution in
[pmndrs/react-three-fiber#2711
- [@&#8203;enijar](https://togithub.com/enijar) made their first
contribution in
[pmndrs/react-three-fiber#2772

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.2...v8.11.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
itsdouges pushed a commit to itsdouges/react-three-fiber that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createRoot errors with HTMLCanvasElement is not defined
1 participant