Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies, normalize testing #607

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

wiledal
Copy link
Member

@wiledal wiledal commented Jan 29, 2024

Description

  • Update some high-level dependencies
  • Update test suite dependencies location
  • Add .yarnrc.yml to support yarn 4
    • This is the recommended way to go, but not supported on Vercel, so let's skip for now

Problems with this update:

  • r3/rapier in 'independent' stepping mode, relies on requestAnimationFrame, which breaks testing when running tests outside of a browser environment
    • We solve this by running tests with the happy-dom or jsdom environment
  • New versions of three-stdlib (common dependency in all r3/* libs) has a lottiejs implementation which is optimized for ssr, and does some canvas operations immediately when run in a browser environment. This breaks tests.
    • To fix this, we can run in jsdom, and apply vitest-canvas-mock in the setup-file
  • Unfortunately, for some reason, the Vercel deployment of the demo breaks when updating any of these libraries.
    • Switching from happy-dom to jsdom breaks Vercel deployment
    • Updating vitest to the latest version breaks Vercel deployment

As I personally don't have access to the Vercel deployment logs or settings, it's nearly impossible to replicate. It's very odd that the testing suite, which is not even run on Vercel, would be affecting the deployment.

Further work is needed to make this up to date with current versions of all the dependent software.

Type of change

  • 📦 Other (tests, refactoring, docs, etc.)

Checklist:

  • 🔍 I have performed a self-review of my code
  • 🟢 All new and existing unit tests pass

Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: 31e5ba6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant