fix(OrbitControls): make "wheel" listener passive #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| scope.domElement.addEventListener('wheel', onMouseWheel) | ||
| scope.domElement.addEventListener('wheel', onMouseWheel, { passive: true }) |
There was a problem hiding this comment.
I believe we need this parameter in dispose as well.
There was a problem hiding this comment.
I don't think we should, since EventTarget.removeEventListener signature doesn't have passive prop in its options
CodyJasonBennett
changed the title
|
🎉 This PR is included in version 2.29.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why / What
Resolves: #352
Checklist
Documentation updatedStorybook entry added