feat: Support promise in watch util #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements pmndrs#507
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 554fc73:
|
|
Thanks for working on it. Been busy, but hopefully, I'll be able to take a look sometime soon. |
dai-shi
requested changes
Nov 25, 2023
dai-shi
reviewed
Nov 25, 2023
dai-shi
reviewed
Nov 25, 2023
dai-shi
reviewed
Nov 25, 2023
dai-shi
reviewed
Nov 26, 2023
| }) | ||
|
|
||
| vi.runAllTimers() | ||
| await waitPromise |
There was a problem hiding this comment.
In this instance yes - because whilst the timers will be run - the code is still synchronous and won't wait for the other scheduled tasks to finish - like the promise itself which is scheduled as a macro task so it would resolve after the current function call. It's similar to why you do await Promise.resolve()
dai-shi
reviewed
Nov 26, 2023
dai-shi
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
#507
Summary
Updates the watch util to support a promise callback. Proxies are subscribed to immediately to improve the time to first callback. This way a proxy can be subscribed to before the promise finishes fully.
Check List
yarn run prettierfor formatting code and docs