Feat: Support for New Semantic Release Version.

[w4rlock]

Please

I need to merge theses changes.

Theses changes resolve next error (ERR_REQUIRED_ESM)

• Support for semantic release version
• Support for Node 18
• Fix Unit Test
• Fix Code Linters
• Tools integration for code styling (prettier, eslint)

[achingbrain]

I think this might need a further fix in https://github.com/semantic-release/semantic-release - I'm experimenting with a fork containing this PR and pmowrer/semantic-release-plugin-decorators#31 and get:

[11:04:38 AM] [semantic-release] › ✘  An error occurred while running semantic-release: Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work/helia-strings/helia-strings/node_modules/semantic-release-monorepo/src/index.js from /home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js not supported.
Instead change the require of index.js in /home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js to a dynamic import() which is available in all CommonJS modules.
    at file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js:38:32
    at async default (file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js:36:11)
    at async Module.default (file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/index.js:271:34)
    at async default (file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/cli.js:55:5) {
  code: 'ERR_REQUIRE_ESM'
}

[pdecat]

I think this might need a further fix in https://github.com/semantic-release/semantic-release - I'm experimenting with a fork containing this PR and pmowrer/semantic-release-plugin-decorators#31 and get:

[11:04:38 AM] [semantic-release] › ✘  An error occurred while running semantic-release: Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work/helia-strings/helia-strings/node_modules/semantic-release-monorepo/src/index.js from /home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js not supported.
Instead change the require of index.js in /home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js to a dynamic import() which is available in all CommonJS modules.
    at file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js:38:32
    at async default (file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/lib/get-config.js:36:11)
    at async Module.default (file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/index.js:271:34)
    at async default (file:///home/runner/work/helia-strings/helia-strings/node_modules/semantic-release/cli.js:55:5) {
  code: 'ERR_REQUIRE_ESM'
}

@achingbrain I went down the same rabbit hole, and discovered that according to the comment in
semantic-release/semantic-release#2569, extends needs to:

references to plugin files in configs need to include the file extension because of executing in an ESM context

So the following configuration works:

{
  "extends": "./node_modules/semantic-release-monorepo/package.json"
}

Not sure why they didn't replace createRequire/require() by import() as it seems to work for both CommonJS and ESM:

diff --git a/lib/get-config.js b/lib/get-config.js
index 429577e..b75e375 100644
--- a/lib/get-config.js
+++ b/lib/get-config.js
@@ -1,6 +1,5 @@
 import { dirname, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
-import { createRequire } from "node:module";

 import { castArray, isNil, isPlainObject, isString, pickBy } from "lodash-es";
 import { readPackageUp } from "read-pkg-up";
@@ -14,7 +13,6 @@ import { parseConfig, validatePlugin } from "./plugins/utils.js";

 const debug = debugConfig("semantic-release:config");
 const __dirname = dirname(fileURLToPath(import.meta.url));
-const require = createRequire(import.meta.url);

 const CONFIG_NAME = "release";

@@ -35,7 +33,7 @@ export default async (context, cliOptions) => {
     options = {
       ...(await castArray(extendPaths).reduce(async (eventualResult, extendPath) => {
         const result = await eventualResult;
-        const extendsOptions = require(resolveFrom.silent(__dirname, extendPath) || resolveFrom(cwd, extendPath));
+        const extendsOptions = import(resolveFrom.silent(__dirname, extendPath) || resolveFrom(cwd, extendPath));

         // For each plugin defined in a shareable config, save in `pluginsPath` the extendable config path,
         // so those plugin will be loaded relative to the config file

[bryanjtc]

Any update on this?

[Julian-B90]

@pmowrer can you merge this?

[jcapogna]

Can this get merged? This is a pretty big issue as it forces users of semantic-release-monorepo to downgrade plugins that are now ESM only.

[bryanjtc]

@pmowrer

[jcapogna]

FYI - I created #138 to document which plugins need to be downgraded due to lack of ESM support in semantic-release-monorepo.

[pmowrer]

Even if this was merged, the build is broken. This project relied on travis-ci but that appears to have been busted a long time ago when travis-ci underwent big changes. The build process needs to be moved to github actions

[jcapogna]

That's good context @pmowrer. I also don't even know if this change works or solves the problems it needs to.

Do you think you could create an issue for fixing the build and explaining what needs to be done? Then maybe someone in the community can work on it. Not sure if that requires adding some users with higher permissions to this project to set up GitHub actions.

[FrederickEngelhardt]

Any ETA on this being merged / published? Is there something blocking these changes from going in?

[junaidrsd]

Any updates on this?

[bryanjtc]

I think this pr should be simplified. Just convert the project to esm and support new semantic release versions. It should be easier to review with fewer changes.

[jcapogna]

@bryanjtc It sounds like another hurdle is that the build for this project is broken and needs to be fixed.

[bryanjtc]

@bryanjtc It sounds like another hurdle is that the build for this project is broken and needs to be fixed.

I created a new pr, without the prettier changes to make reviewing them easier. See: #143
It works without errors in a testing pipeline on my fork of this repo: See: https://github.com/bryanjtc/semantic-release-monorepo/actions/runs/6716255451/job/18252207700. It uses a custom patch of semantic-release to allow using an esm extended configuration.

[bryanjtc]

I removed the custom patch and bundled code as solution for this comment: #143 (comment)
Just published my pr as a new package semantic-release-monorepo-esm
v1.0.10 should work without issues.

[github-actions]

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[pmowrer]

Thanks for doing the work @w4rlock! Ended up merging @bryanjtc's PR because of the smaller diff. Happy to consider any improvements here as follow-on. Lmk

[jcapogna]

Thanks for getting this out. Huge quality of life improvement :)