Supporting .NET8 updates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception is batch because Swashbuckle does not support net8
Batch uses Swashbuckle net6 dlls
With special net6 install for batch project Signed-off-by: Phillip Ngan <phillip.ngan@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
4 tasks
paulyuk
commented
Feb 17, 2024
| @@ -34,15 +34,15 @@ Run the `SmartDevice.Service`, which will start service itself and the Dapr side | |||
| <!-- STEP | |||
| name: Run actor service | |||
| expected_stdout_lines: | |||
| - "Request finished HTTP/1.1 GET http://127.0.0.1:5001/healthz - - - 200" | |||
| - "Request finished HTTP/1.1 GET http://127.0.0.1:5001/healthz - 200" | |||
There was a problem hiding this comment.
This is the line of output from healthz that changed, causing our tests to fail. by changing the expected out we fix it back up again.
paulyuk
commented
Feb 17, 2024
| @@ -1,5 +1,5 @@ | |||
| DAPR_CLI_VERSION: 1.12.0 | |||
| DAPR_RUNTIME_VERSION: 1.13.0-rc.2 | |||
| DAPR_RUNTIME_VERSION: 1.13.0-rc.4 | |||
There was a problem hiding this comment.
hopefully this avoids a merge conflict with release-1.13.
paulyuk
commented
Feb 17, 2024
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Swashbuckle.AspNetCore" Version="6.2.3" /> |
There was a problem hiding this comment.
Reviewed with .NET SDK maintainers in Dapr and they agree with this. Also tests pass.
paulyuk
commented
Feb 17, 2024
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Swashbuckle.AspNetCore" Version="6.2.3" /> |
There was a problem hiding this comment.
Reviewed with .NET SDK maintainers in Dapr and they agree with this. Also tests pass.
pngan
force-pushed
the
ConvertToNet8-on-release-1.13
branch
2 times, most recently
from
05fce33
to
78f35dc
Compare
Signed-off-by: Phillip Ngan <4557674+pngan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These complementary updates do the following:
dapr runcommands (no more path not found)Issue reference
#980
#987
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: