Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not download pnpm from get.pnpm.io #46

Merged
merged 2 commits into from May 28, 2022
Merged

fix: do not download pnpm from get.pnpm.io #46

merged 2 commits into from May 28, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented May 28, 2022

close #44
close #22

@KSXGitHub
Copy link
Collaborator

This would effectively render the version input key pointless. Is this your intention?

@zkochan
Copy link
Member Author

zkochan commented May 28, 2022

Not correct.

Nothing changed regarding version. pnpm is installing the specified version of pnpm. Before this change, pnpm was downloaded. This was causing issues. So now the pnpm which installs pnpm is committed to the project.

@KSXGitHub
Copy link
Collaborator

Ah, I see. I somehow forgot the workings of the code that I wrote/merged myself lol.

@zkochan zkochan merged commit 958500f into master May 28, 2022
@zkochan
Copy link
Member Author

zkochan commented May 28, 2022

Could you release it? I don't know how it is released.

Copy link
Collaborator

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are 2 pnpm.js files: One in dist, the other in src/install-pnpm. Is this excessive?

@zkochan
Copy link
Member Author

zkochan commented May 28, 2022

it might be

why is the dist folder committed at all?

@KSXGitHub
Copy link
Collaborator

Wait, did you just merge? I was meant to make more review comment!

@zkochan
Copy link
Member Author

zkochan commented May 28, 2022

ok, comment, I'll make another PR

@KSXGitHub
Copy link
Collaborator

Could you release it? I don't know how it is released.

Step 0: Make sure that you have enabled Two Factor Authentication (2-FA) on GitHub.
Step 1: Use git tag to tag a version (and then push the tag).
Step 2: Go to the Release Page on GitHub.
Step 3: Click on the tag.
Step 4: Create a release.
Step 5: Remember to check the Marketplace checkbox.

@zkochan
Copy link
Member Author

zkochan commented May 28, 2022

Thanks, we'll have to add that to a CONTRIBUTING.md

@KSXGitHub
Copy link
Collaborator

why is the dist folder committed at all?

The dist contains index.js which is what the "engine" of GitHub Actions would execute. Because the "engine" can't understand TypeScript.

@zkochan
Copy link
Member Author

zkochan commented May 28, 2022

can we generate it before packing?

@KSXGitHub
Copy link
Collaborator

can we generate it before packing?

I think there's a command in package.json that generates dist/index.js. I always make sure to execute it before commit, though not automatically yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants