Add proper support for PowerShell #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerShell can’t properly pass string arguments containing the `&` symbol to Windows Command Prompt scripts, if the string containing the ampersand doesn’t have spaces, due to how the cmd prompt parses the `&` as a command delimiter, even in a string. This patch adds a workaround by generating a third script specifically for PowerShell.
This was referenced May 31, 2018
|
LGTM but I wonder if we should create these files on non-Windows by default. |
|
Well, PowerShell 6 and newer can be installed on non‑Windows platforms as well, unlike the Windows Command Prompt, which is Windows only. Because of this, I’d prefer to also generate the PowerShell scripts on non-windows platforms as well, because that’s the only way to be sure that PowerShell will handle the script correctly. |
|
Yes, I understand that. Sobwe can add a config to pnpm. Something like
`--power-shell-bin`. It will be true by default on windows and users can
make it true on non-windows
…On Sun, Jul 8, 2018, 19:14 ExE Boss ***@***.***> wrote:
Well, PowerShell 6 can be installed on non‑Windows platforms as well,
unlike the Windows Command Prompt, which is Windows only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB1pm6kOafat_i4TBkOHUQnmsgVC0CRnks5uEi_LgaJpZM4ULy_A>
.
|
|
You could also check if the |
|
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerShell can’t properly pass string arguments containing the
&symbol to Windows Command Prompt scripts, if the string containing the ampersand doesn’t have spaces, due to how the cmd prompt parses the&as a command delimiter, even in a string.This patch adds a workaround by generating a third script specifically for PowerShell.
Additional notes:
#!/usr/bin/env pwshshebang line is in the PowerShell script because PowerShell can be installed on a Unix system since version 6.&character to a npm cli package from PowerShell on Windows pnpm#1199review?(@zkochan)