Skip to content
This repository has been archived by the owner on Oct 15, 2023. It is now read-only.

fix: should find all cycles info when cycle exists #2

Merged
merged 2 commits into from May 6, 2023

Conversation

await-ovo
Copy link
Member

fix pnpm/pnpm#5059

Given a graph like following:

   graphSequencer({
      graph: new Map([
        ['a', ['c']],
        ['b', ['c']],
        ['c', ['b']],
      ]),
      groups: [
        ['a', 'b', 'c'],
      ],
    })

It will output { safe: false, chunks: [ [ 'a' ], [ 'b' ], [ 'c' ] ], cycles: [] } currently, you can see that the cycle array is empty, it should have been cycle: [['c', 'b']]

@await-ovo await-ovo requested a review from zkochan May 6, 2023 07:54
@zkochan zkochan merged commit 978f081 into pnpm:main May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to show cycle dependencies info
2 participants