Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.ts #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update index.ts #3

wants to merge 1 commit into from

Conversation

kevinkhill
Copy link

I would like to have the opts passed to the updater function so that I can conditionally console.log when using the --test flag.

export default (workspaceDir, { test }) => {
  return {
    'package.json': (manifest, dir) => {
      if (test) {
        console.log(`Failed @`, dir)
      }
      return {
        ...manifest,
        author: 'Foo Bar',
      }
    },
  }
}

Thoughts?

I would like to have the `opts` passed to the updater function so that I can conditionally `console.log` when using the `--test` flag.

```typescript
export default (workspaceDir, { test }) => {
  return {
    'package.json': (manifest, dir) => {
      if (test) {
        console.log(`Failed @`, dir)
      }
      return {
        ...manifest,
        author: 'Foo Bar',
      }
    },
  }
}
```

Thoughts?
@zkochan
Copy link
Member

zkochan commented Aug 9, 2022

why don't you just print it always?

@kevinkhill
Copy link
Author

I was not prepared to justify my request, heh... personal preference? I like being able to have my CLI tools be noisy or quiet depending on how I am using them.

Also, maybe....

It felt like a cheap and easy way to contribute to something open source?

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants