Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pnpm doctor docs and engines.node #347

Merged
merged 3 commits into from Oct 22, 2022
Merged

Conversation

lvqq
Copy link
Member

@lvqq lvqq commented Oct 22, 2022

Related PR: pnpm/pnpm#5526

Node.js version from the documentation of docusaurus

@stackblitz
Copy link

stackblitz bot commented Oct 22, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@lvqq lvqq temporarily deployed to deploy October 22, 2022 11:57 Inactive
@lvqq lvqq temporarily deployed to deploy October 22, 2022 12:02 Inactive
@lvqq lvqq changed the title feat: add pnpm doctor docs feat: add pnpm doctor docs and engines.node Oct 22, 2022
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanpicado
Copy link
Member

juanpicado commented Oct 22, 2022

@lvqq thanks by was already added by Zoltan here pnpm/pnpm.github.io@9872104

Maybe you can just redo the PR only for the node engines

@zkochan zkochan temporarily deployed to deploy October 22, 2022 19:21 Inactive
@zkochan zkochan temporarily deployed to deploy October 22, 2022 19:23 Inactive
@zkochan zkochan merged commit 8eb52a5 into pnpm:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants