fix: don't break when injecting a dependency with broken symlinks

close #5598

packages/directory-fetcher/src/index.ts

@@ -1,4 +1,4 @@
-import { promises as fs } from 'fs'
+import { promises as fs, Stats } from 'fs'
 import path from 'path'
 import type { DirectoryFetcher, DirectoryFetcherOptions } from '@pnpm/fetcher-base'
 import { safeReadProjectManifestOnly } from '@pnpm/read-project-manifest'
@@ -65,7 +65,14 @@ async function _fetchAllFilesFromDir (
     .filter((file) => file !== 'node_modules')
     .map(async (file) => {
       const filePath = path.join(dir, file)
-      const stat = await fs.stat(filePath)
+      let stat: Stats
+      try {
+        stat = await fs.stat(filePath)
+      } catch (err: any) { // eslint-disable-line @typescript-eslint/no-explicit-any
+        // Broken symlinks are skipped
+        if (err.code === 'ENOENT') return
+        throw err
+      }
       const relativeSubdir = `${relativeDir}${relativeDir ? '/' : ''}${file}`
       if (stat.isDirectory()) {
         const subFilesIndex = await _fetchAllFilesFromDir(filePath, relativeSubdir)

packages/directory-fetcher/test/fixtures/pkg-with-broken-symlink/not-exists

@@ -0,0 +1 @@
+broken-symlink

packages/directory-fetcher/test/fixtures/pkg-with-broken-symlink/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "simple-pkg",
+  "version": "0.0.0"
+}

packages/directory-fetcher/test/index.ts

@@ -79,3 +79,26 @@ test('fetch a directory that has no package.json', async () => {
     'index.js',
   ])
 })
+
+test('fetch does not fail on package with broken symlink', async () => {
+  process.chdir(f.find('pkg-with-broken-symlink'))
+  const fetcher = createDirectoryFetcher()
+
+  // eslint-disable-next-line
+  const fetchResult = await fetcher.directory({} as any, {
+    directory: '.',
+    type: 'directory',
+  }, {
+    lockfileDir: process.cwd(),
+  })
+
+  expect(fetchResult.local).toBe(true)
+  expect(fetchResult.packageImportMethod).toBe('hardlink')
+  expect(fetchResult.filesIndex['package.json']).toBe(path.resolve('package.json'))
+
+  // Only those files are included which would get published
+  expect(Object.keys(fetchResult.filesIndex).sort()).toStrictEqual([
+    'index.js',
+    'package.json',
+  ])
+})